Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast getLoadingTimeout() to int in template #2661

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Cast getLoadingTimeout() to int in template #2661

merged 1 commit into from
Oct 19, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 19, 2022 •
edited
Loading

Description (*)

See #2656

Related Pull Requests

  1. See Add loading delay adminhtml #2426

Fixed Issues (if relevant)

  1. Fixes WYSIWYG editor doesn't open on product admin page #2656

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Template : admin Relates to admin template labels Oct 19, 2022
@elidrissidev elidrissidev merged commit f48e168 into OpenMage:1.9.4.x Oct 19, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit f48e168. ± Comparison against base commit 15f83af.

@sreichel sreichel deleted the hotfix/loading-timeout branch October 19, 2022 19:24
@kiatng kiatng mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidrissidev elidrissidev elidrissidev approved these changes

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WYSIWYG editor doesn't open on product admin page
4 participants
@sreichel @kiatng @addison74 @elidrissidev