Do not autoload captcha class when disabled #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiatng
approved these changes
Nov 7, 2022
|
Yes. |
|
is it ok if we release before merging this? since I got enough reviews to merge #2571? |
|
Yes, this is not really important. |
sreichel
approved these changes
Nov 7, 2022
|
@sreichel I made a mistake and merged without squashing (since I changed the default merge strategy while merging the whole v19 -> v20 PR) and now the diff looks awful: v19.4.19...1.9.4.x Is it possible to fix it without reverting? sorry :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Blackfire, I found when captcha is disabled in configuration, a class is autoloaded.
I dislike.
OpenMage 20.0.16 / PHP 8.0.25
Contribution checklist