Bugfix to make exchange rate data with fixer.io work again #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking at the documentation at https://fixer.io/documentation, and I can see they still mention the current URL in their examples (only difference is
|
|
@elidrissidev I've tried this url at first but it didn't work. When you want to get an api key from fixer.io you will be redirected to apilayer.com. So you have to use the new url. |
|
Tested and confirmed. @dbachmann opened PR at your repo. |
sreichel
approved these changes
Nov 16, 2022
fballiano
approved these changes
Nov 16, 2022
|
@sreichel Tested your code. Works perfectly. Good job. |
Unit Test Results1 files 1 suites 0s ⏱️ Results for commit fa5f628. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
A customer of mine wanted to update the exchange rates in his shop. I wanted to use fixer.io but I got an error. So I looked into the code and looked into the documentation of fixer which is now part of apilayer.com. I changed the api url and a parameter name. When I entered my api key and tested this, everything worked like charm and I got the correct exchange rates.
Manual testing scenarios (*)