Add autocomplete attribute to known password fields. #2700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Add "autocomplete" attribute to password fields on customer-facing forms. This is not really a security issue in my opinion, but this change is intended to help meet PCI attestation requirements. Some vulnerability scanners are known to flag this as an issue. For example: https://www.tenable.com/plugins/nessus/42057
I attempted to use the most appropriate value for the attribute (off or new-password). These changes should not have any noticeable impact on users.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)