Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete ACL resources from DB #2706

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Remove obsolete ACL resources from DB #2706

merged 2 commits into from
Nov 15, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 14, 2022

Description (*)

Runs ... thanks @kiatng

DELETE FROM admin_rule 
WHERE `resource_id` IN (
  'admin/page_cache',
  'admin/system/config/moneybookers', 
  'admin/system/extensions', 
  'admin/system/extensions/local', 
  'admin/system/extensions/custom', 
  'admin/system/tools/backup',
  'admin/system/tools/backup/rollback',
  'admin/system/tools/compiler',
  'admin/xmlconnect',
  'admin/xmlconnect/mobile',
  'admin/xmlconnect/admin_connect',
  'admin/xmlconnect/queue',
  'admin/xmlconnect/history',
  'admin/xmlconnect/templates'
)

Related Pull Requests

  1. See Removed dead code #2339

Fixed Issues (if relevant)

  1. Fixes Zend_Acl_Exception: Resource 'admin/page_cache' not found #2705

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Admin Relates to Mage_Admin label Nov 14, 2022
elidrissidev
elidrissidev previously approved these changes Nov 14, 2022
….4.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elidrissidev elidrissidev merged commit 0145969 into OpenMage:1.9.4.x Nov 15, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit 0145969.

@sreichel sreichel deleted the remove-osbsolete-acl branch November 15, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Admin Relates to Mage_Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants