-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep current selection for Related, Up-sells, Cross-sells, Associated grids #2715
Conversation
I'm not sure I understand the current behaviour and the wanted one |
I think it's bug: backend product page > Up-Sells tab > grid
However, the fix doesn't seem to work for me. |
I tested your scenario, with the current PR, it works for me. |
This is a nasty bug. I was able to reproduce it easily. If you use Magento Sample Pack, just edit the product Silver Desert Necklace, go to Up-sells, select in the grid Any and press the [Search] button. You will get 30 product pages in the grid. Select one product at a time on the first 4 pages then go back without saving the product. All selections not made no longer exist, they are gone. The funny part is that the interface notices the change and displays the diskette icon for saving next to Up-sells. |
I applied this PR and the issue is solved. All checkmarks remain on each page in the grid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
merged and cherrypicked to v20 |
Description
Go to Catalog > Products and choose any product.
For Related, Up-sells, Cross-sells, Associated (for grouped products) grids.
Try Sales / Order grid, this is the same thing.
This is an extract of #1379.
OpenMage 20.0.17 / PHP 8.0.25
Contribution checklist