Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class active on parent menu item #2738

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add class active on parent menu item #2738

merged 1 commit into from
Dec 1, 2022

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 17, 2022

Description

This PR will allow to "highlight" current menu items of backend, and not only for the "last".

permissions

Yes, many menu items does not use the right ->setActiveMenu(), so this will not work everywhere.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Nov 17, 2022
@fballiano fballiano merged commit 689c749 into OpenMage:1.9.4.x Dec 1, 2022
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 689c7496. ± Comparison against base commit 7f75489.

@luigifab luigifab deleted the active-menu branch December 1, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants