Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces full class name with self #2749

Merged
merged 5 commits into from
Nov 20, 2022
Merged

Replaces full class name with self #2749

merged 5 commits into from
Nov 20, 2022

Conversation

sreichel
Copy link
Contributor

Description (*)

Cant reopen old PR ...

Related Pull Requests

  1. See Replaces full class name with self #962

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

sreichel and others added 5 commits May 11, 2020 02:27
# Conflicts:
#	app/code/core/Mage/Api2/Model/Resource.php
#	app/code/core/Mage/Captcha/Helper/Data.php
#	app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php
#	app/code/core/Mage/Paypal/Block/Iframe.php
#	app/code/core/Mage/Paypal/Model/Express/Checkout.php
#	app/code/core/Mage/SalesRule/Model/Rule.php
@github-actions github-actions bot added Component: Api2 Relates to Mage_Api2 Component: Captcha Relates to Mage_Captcha Component: Core Relates to Mage_Core Component: Directory Relates to Mage_Directory Component: ImportExport Relates to Mage_ImportExport Component: Oauth Relates to Mage_Oauth Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule labels Nov 20, 2022
@fballiano fballiano merged commit 3453d22 into OpenMage:1.9.4.x Nov 20, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 3453d22. ± Comparison against base commit 2afbba9.

@sreichel sreichel deleted the cs/self-vs-fcn branch November 20, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Api2 Relates to Mage_Api2 Component: Captcha Relates to Mage_Captcha Component: Core Relates to Mage_Core Component: Directory Relates to Mage_Directory Component: ImportExport Relates to Mage_ImportExport Component: Oauth Relates to Mage_Oauth Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants