Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unreachable code #2775

Merged
merged 7 commits into from
Dec 4, 2022
Merged

Removed unreachable code #2775

merged 7 commits into from
Dec 4, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 2, 2022 •
edited
Loading

Description (*)

Removed code after return or throw statements.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Paygate Relates to Mage_Paygate Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Sitemap Relates to Mage_Sitemap phpstan labels Dec 2, 2022
@fballiano fballiano merged commit c7547af into OpenMage:1.9.4.x Dec 4, 2022
@sreichel sreichel deleted the unreacable branch December 4, 2022 06:42
@fballiano fballiano mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Paygate Relates to Mage_Paygate Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Sitemap Relates to Mage_Sitemap phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng