Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Remove documentation hints, ref #1536 #2815

Merged
merged 2 commits into from
Dec 18, 2022
Merged

[Backport] Remove documentation hints, ref #1536 #2815

merged 2 commits into from
Dec 18, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 16, 2022 •
edited
Loading

Description (*)

Backport and fixed some diffs between v19/v20

Related Pull Requests

  1. See Remove the documentation Hint "(?)" functionality #1536
  2. See Reinstate getters and setters for $_pageHelpUrl which some third party modules still use #1610
  3. See Zend registry - removed method offset exists (using parental) #1873

Questions or comments

@fballiano merge to v20 pls too.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: lib/Zend Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Wishlist Relates to Mage_Wishlist documentation JavaScript Relates to js/* Template : admin Relates to admin template Template : rwd Relates to rwd template translations Relates to app/locale labels Dec 16, 2022
@fballiano
Copy link
Contributor

couldn't we just cherry-pick ced97cd?

@sreichel
Copy link
Contributor Author

No, b/c #1610. Also added/reverted/syncd some other changes betwenn 19/20.

@fballiano fballiano merged commit 4d1869e into OpenMage:1.9.4.x Dec 18, 2022
@sreichel sreichel deleted the remove-hints branch December 18, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Wishlist Relates to Mage_Wishlist documentation JavaScript Relates to js/* Template : admin Relates to admin template Template : rwd Relates to rwd template translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74