Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan: Mage_Cms #2818

Merged
merged 2 commits into from
Dec 18, 2022
Merged

phpstan: Mage_Cms #2818

merged 2 commits into from
Dec 18, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 17, 2022

Description (*)

Updated DOCs. Fixed some errors.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php phpstan labels Dec 17, 2022
addison74
addison74 previously approved these changes Dec 17, 2022
@fballiano
Copy link
Contributor

this one has a conflict now

# Conflicts:
#	phpstan.dist.baseline.neon
@fballiano fballiano merged commit 9e6ac30 into OpenMage:1.9.4.x Dec 18, 2022
@sreichel sreichel deleted the phpstan/mage-cms branch December 18, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants