Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing null and array to string conversion error #2824

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Fix passing null and array to string conversion error #2824

merged 1 commit into from
Dec 18, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 18, 2022

Description (*)

Fixes a bug when passing not a full config path to Mage::getStoreConfigFlag(). Also fixes php8.1 passing null to strtolower().

Related Pull Requests

Manual testing scenarios (*)

// $test = Mage::getStoreConfigFlag('dev/css/merge_css_files');
$test = Mage::getStoreConfigFlag('dev/css');
var_dump($test);

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Dec 18, 2022
@sreichel sreichel added the PHP 8.1 Related to PHP 8.1 label Dec 18, 2022
@fballiano fballiano merged commit fb71912 into OpenMage:1.9.4.x Dec 18, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit fb71912.

@sreichel sreichel deleted the fix/get-store-config-flag branch December 19, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mage.php Relates to app/Mage.php PHP 8.1 Related to PHP 8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants