Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: fixes "Call to function is_null ..." #2831

Merged
merged 10 commits into from
Dec 22, 2022
Merged

phpstan: fixes "Call to function is_null ..." #2831

merged 10 commits into from
Dec 22, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 21, 2022 •
edited
Loading

Description (*)

Some fixes and ...

@fballiano i know you dont like additional files in root dir, but this adds phpstan.issues.neon.

That are issues that i always see, but cant/wont fix on-the-fly with changing some phpdocs... i'd like to have them seperated from baseline (for next time).

Also excluded Mage_Backup & Mage_PageCache from default checks.

(btw .. just for you phpstan/phpstan#8567 😎)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Paygate Relates to Mage_Paygate labels Dec 21, 2022
@github-actions github-actions bot added Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sendfriend Relates to Mage_Sendfriend Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Uploader Relates to Mage_Uploader Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan labels Dec 21, 2022
@sreichel
Copy link
Contributor Author

@fballiano pls ignore that new file.

We're (slowly) coming to a point where phpstan does find "real" issues, not only incomplete docs.

I'd like have that errors removed from baseline - and and dont want it in default config.

fballiano
fballiano previously approved these changes Dec 22, 2022
View reviewed changes
@fballiano
Copy link
Contributor

(btw .. just for you phpstan/phpstan#8567 😎)

❤️ 😅

addison74
addison74 previously approved these changes Dec 22, 2022
View reviewed changes
@sreichel
Merge branch '1.9.4.x' into phpstan/update-2
9d02136 
# Conflicts:
#	phpstan.dist.baseline.neon
@sreichel sreichel dismissed stale reviews from addison74 and fballiano via 9d02136 December 22, 2022 20:34
@sreichel sreichel mentioned this pull request Dec 22, 2022
Merged
@fballiano fballiano merged commit 3b1dac7 into OpenMage:1.9.4.x Dec 22, 2022
@sreichel sreichel deleted the phpstan/update-2 branch December 22, 2022 21:03
@sreichel sreichel mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sendfriend Relates to Mage_Sendfriend Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Uploader Relates to Mage_Uploader Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74