Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: working on level 3 #2840

Merged
merged 2 commits into from
Dec 24, 2022
Merged

phpstan: working on level 3 #2840

merged 2 commits into from
Dec 24, 2022

Conversation

sreichel
Copy link
Contributor

Description (*)

... for some progress.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax phpstan labels Dec 24, 2022
@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Dec 24, 2022
@fballiano fballiano merged commit 76d6e6a into OpenMage:1.9.4.x Dec 24, 2022
@sreichel sreichel deleted the phpstan/daily-3 branch December 25, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74