Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load dev shell scripts as composer module #2853

Merged
merged 7 commits into from
Dec 28, 2022
Merged

Load dev shell scripts as composer module #2853

merged 7 commits into from
Dec 28, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 26, 2022

Description (*)

... they are not need for production ...

Repos:

All credits to @justinbeaty 👍

READMEs will be added later.

Related Pull Requests

  1. Add OpenMage Contributors Copyright #2295
  2. Add translation helper shell script #2332

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added composer Relates to composer.json shell Relates to shell scripts labels Dec 26, 2022
fballiano
fballiano previously approved these changes Dec 26, 2022
@fballiano
Copy link
Contributor

beautiful and clean

addison74
addison74 previously approved these changes Dec 26, 2022
.gitignore Outdated Show resolved Hide resolved
@fballiano fballiano self-requested a review December 26, 2022 14:18
@fballiano fballiano dismissed their stale review December 26, 2022 14:18

Wrote a comment

fballiano
fballiano previously approved these changes Dec 26, 2022
@sreichel sreichel marked this pull request as draft December 27, 2022 01:01
@sreichel sreichel marked this pull request as ready for review December 27, 2022 17:28
@sreichel sreichel marked this pull request as draft December 27, 2022 17:32
@sreichel sreichel marked this pull request as ready for review December 27, 2022 18:17
fballiano
fballiano previously approved these changes Dec 27, 2022
@fballiano fballiano merged commit a1605eb into OpenMage:1.9.4.x Dec 28, 2022
@sreichel sreichel deleted the dev-scripts branch December 28, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json phpstan shell Relates to shell scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants