Hotfix: php7 has no return type "mixed" #2856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
#2802 made some changes for php8, but was not tested with php7.
Problem: return type
mixed
was added with php8 .... https://php.watch/versions/8.0/mixed-typeThis is fixed with this PR.
Reverted phpstan config to run with composer platform version (PHP7.3). Sadly phpstan does not detect that ...
Reported issue here: phpstan/phpstan#8597
Related Pull Requests
Fixed Issues (if relevant)
Fatal error: Uncaught TypeError: Return value of Varien_Object::offsetGet() must be an instance of mixed, string returned in /var/www/html/lib/Varien/Object.php:876
Manual testing scenarios (*)
Questions or comments
Wonder that is not covered by code checks.
Contribution checklist (*)