Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github URL for patch files #2871

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Use github URL for patch files #2871

merged 1 commit into from
Dec 30, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 30, 2022

Description (*)

Patch files are not found when installing OM via composer with custom magento-root-dir (like htdocs).

Related Pull Requests

  1. See OpenMage/magento-lts#2861

Manual testing scenarios (*)

  1. composer require openmage/magento-lts
  "extra": {
        "enable-patching": true,
        "magento-root-dir": "htdocs",
        "magento-core-package-type": "magento-source"
  }
  1. "enable-patching": true, has to be added!

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the composer Relates to composer.json label Dec 30, 2022
@fballiano fballiano merged commit fcb45a3 into OpenMage:1.9.4.x Dec 30, 2022
@sreichel sreichel deleted the fix/patches branch December 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants