Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ACL for customer link of orders #2933

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Check ACL for customer link of orders #2933

merged 1 commit into from
Jan 14, 2023

Conversation

luigifab
Copy link
Contributor

Description

This PR remove the link to the customer edit page when admin user is not authorized.

image

Manual testing scenarios

  • Create an user with a role that can access only Orders
  • Login with this user and go to Sales / Orders / Any order (not guest)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jan 14, 2023
@elidrissidev elidrissidev merged commit 29dd4b1 into OpenMage:1.9.4.x Jan 14, 2023
@luigifab luigifab deleted the acl-link branch January 14, 2023 11:48
@elidrissidev
Copy link
Member

@fballiano Couldn't cherry-pick this one to 20.0

@fballiano
Copy link
Contributor

cherrypicked to v20

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants