Added a forced refresh if the user modifies the minicart while being on the cart page #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely okay IMO. IE9 is EOL for 3 years now. |
|
LGTM but I will test it tomorrow. I've been looking through the webserver logs for the last year and I haven't found any monthly records related to IE 9 and 10. Only IE 11 around 20 visits per month, most likely a Windows 7 or 10 user who didn't want to upgrade to a modern browser. |
addison74
approved these changes
Jan 24, 2023
|
thanks guys, cherrypicked to v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is described in issue #2204.
I've checked the body class for the presence of "checkout-cart-index", it should be quite ok.
I've used
document.body.classList.contains("checkout-cart-index")functionality that is compatible with more modern browsers (ie10), is it ok with everybody? otherwise we've to use regex likedocument.body.className.match(/(\s|^)checkout-cart-index(\s|$)/)This PR fixes the problem when removing the product but also when changing its quantity.