Fix bug in admin interface where Bundle Option Is Required setting is not loaded.

[rfeese]

Description (*)

This fixes a bug in the admin area when editing Bundle Items Options on a Bundle type product. When "Is Required" on an Option is set to No, the select element on the screen is not initialized with the selected value from the database because of an oversight in the check for existence of a variable with value zero (in the case of Is Required = "No").

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

1. In Admin interface, Create or Edit a Bundle type product.
2. On the "Bundle Items" tab, Create / Edit an existing Option.
3. Change the Option "Is Required" setting to "No".
4. Save and Continue Edit or Save and return to Edit the product.
5. Notice that the "Is Required" setting reverts back to "Yes" (the first option).

This happens because the javascript that initializes the "Is Required" select element only runs if the value is "Yes" (1) due to the code checking the value of the variable -- "No" (0) evaluates to false.

Note that the Is Required setting is saved correctly based on what currently shows in the Admin screen (Is Required will be set to Yes unless you change it before saving), and appears to be handled correctly in the customer view.

Questions or comments

I think that the intention of the code was to check for the existence of the variable, so I modified the check to look for whether the variable was defined using typeof.

I suspect this type of problem could show up in other places, but have not attempted to find other instances of this yet.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[addison74]

LGTM

[elidrissidev]

Good find. Works as intended.

[fballiano]

merged and cherrypicked to 20.0