Fixed PHP_OS check in cron.php

[elidrissidev]

Description (*)

Some improvements were done previously to cron.php in #2380, including a refactor to $isShellDisabled which decides whether or not to use the shell generate the cron schedules and run them.

The problem comes from the condition !str_contains(strtolower(PHP_OS), 'win'), which is the opposite of what it should be and it'll cause the cron events to be dispatched twice from the lines below:

magento-lts/cron.php

Lines 74 to 79 in e2d5fed

	if ($isShellDisabled) {
	Mage::dispatchEvent('always');
	Mage::dispatchEvent('default');
	} else {
	Mage::dispatchEvent($cronMode);
	}

This was likely caused by confusion over the fact that PHP_OS is set to Darwin in macOS (@fballiano's OS), so with the negation operator it's actually resulting in false which is what you'd expect in a non-win system, so I went ahead and checked for that too.

Related Pull Requests

• See Improvements in cron scripts #2380

Fixed Issues (if relevant)

1. Fixes cron does run twice because of wrong $isShellDisabled check #3112

Manual testing scenarios (*)

1. Add a var_dump($isShellDisabled) to cron.php before the try catch block, and observe the value before and after.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

darwindows 😅 what the heck

the problem was only on windows anyway right?

[elidrissidev]

darwindows 😅 what the heck

the problem was only on windows anyway right?

ikr, it was windows all along!

[fballiano]

merged and 20ed.

PS: I'm trying to change the titles because they're used to generate the release notes...