Fixed logging too many exceptions for payment methods

[fballiano]

In #3179 @addison74 pointed out that, using the backend, and opening an order detail page, some exceptions were logged about missing payment methods.

This is because the list of payment methods tries to load the model (for the payment method) and logs an exception if it's not found.

This is ok in some cases (when the order was paid with a method that has been removed later) but not in all the other cases.

So I thought to kinda rewrite the getPaymentMethodList method of Mage_Payment_Helper_Data.

If I'm not mistaken the before/after output of the getPaymentMethodList method stays the same:
before:

after:

Related Pull Requests

#2939

Fixed Issues

1. Fixes exceptions.log - Errors and Warnings #3179

[addison74]

This PR fixes Sales > Orders > View any Order. No more lines in exceptions.log.

We still have the same issue in Customers > Manage Customers > Edit any Customer. Will you create a new PR for Customers?

(PHP 8.1)

[fballiano]

I thought it was the same but I’ll check it out asap!

[fballiano]

@addison74 I've added the fix for the customer detail page in this PR because it was sharing part of the code ;-)

[addison74]

Tested. No more warnings in the exceptions.log file related to the missing payment methods. For both sections in Backend (View Order and Edit Customer).