Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed openmage's dev-dependencies in PHPUnit workflow #3794

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

Flyingmana
Copy link
Contributor

in this context the dev dependencies are included in the Testfield repository, having them in both messes up phpunits class loading,

Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess your explanation makes sense

@fballiano fballiano changed the title install openmage without dev dependencies in Testfield context Removed openmage's dev-dependencies in PHPUnit workflow Feb 4, 2024
@fballiano fballiano merged commit cc37d58 into OpenMage:main Feb 4, 2024
38 checks passed
@Flyingmana Flyingmana deleted the patch-workflow-phpunit branch February 5, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants