Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote getOpenMageVersion() to be faster #3875

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Rewrote getOpenMageVersion() to be faster #3875

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e1ae5b
Rewrote getOpenMageVersion() to be faster
fballiano Mar 5, 2024
645b508
rtrim instead of trim
fballiano Mar 6, 2024
607d0f9
Rewrote getOpenMageVersion() to be faster
fballiano Mar 6, 2024
89f369f
Merge branch 'main' into fastergetinfo
fballiano Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions app/Mage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,25 +176,24 @@ public static function getVersionInfo()
* Gets the current OpenMage version string
* @link https://openmage.github.io/supported-versions.html
* @link https://semver.org/
*
* @return string
*/
public static function getOpenMageVersion(): string
{
$info = self::getOpenMageVersionInfo();
$versionString = "{$info['major']}.{$info['minor']}.{$info['patch']}";
if ($info['stability'] || $info['number']) {
$stability = $info['stability'];
fballiano marked this conversation as resolved.
Show resolved Hide resolved
$number = $info['number'];

if ($stability || $number) {
$versionString .= '-';
if ($info['stability'] && $info['number']) {
$versionString .= implode('.', [$info['stability'], $info['number']]);
if ($stability && $number) {
$versionString .= "{$stability}.{$number}";
} else {
$versionString .= implode('', [$info['stability'], $info['number']]);
$versionString .= $stability . $number;
}
}
return trim(
$versionString,
'.-'
);

return trim($versionString, '.-');
fballiano marked this conversation as resolved.
Show resolved Hide resolved
fballiano marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
Loading