Bump phpstan/phpstan from 1.10.59 to 1.10.66 #3880
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.59 to 1.10.60. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.59...1.10.60) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
github-actions
bot
added
Component: lib/Varien
|
this change is a mess |
|
@fballiano - I agree, too many errors. |
|
I'm pretty sure some of the errors are false positive, let's wait for new releases before checking further |
|
A newer version of phpstan/phpstan exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@fballiano - We should close this PR. PHPstan version 1.10.63 was released today. |
fballiano
changed the title
|
no need ;-) updated this one so we don't lose some of the work that was already done, let's see if this version works better or not |
|
same disaster |
github-actions
bot
added
the
Component: CatalogSearch
|
@fballiano - Did you manage to fix it? Based on the green color it is ready for approval. |
|
it should be all done, if everything is right |
|
Those lines with |
|
to me they're unfixable and it's a phpstan error. those objects are StdClass and StdClass still support dynamic property while phpstan says it's an error. IMHO it's better to have those comments compared to add a line to the baseline, it looks cleaner |
fballiano
changed the title
fballiano
changed the title
|
I'll merge this, in case there's a problem I'll fix it anyway |
Bumps phpstan/phpstan from 1.10.59 to 1.10.60.
Release notes
Sourced from phpstan/phpstan's releases.
... (truncated)
Commits
95dcea7PHPStan 1.10.606b52280Updated PHPStan to commit 6b522806f09ce95c683ec5012763dcc18dd922e55c5f6cbUpdated PHPStan to commit 5c5f6cb53e7e88324f61a3fdb0598299d394970540b4cfdUpdated PHPStan to commit 40b4cfd86fb409558a113ad73803d58d53b74f89a4b91a1Updated PHPStan to commit a4b91a15faf2e4f8fec1255feec4cfdeecdf455a644c44aUpdated PHPStan to commit 644c44a8f4c27832253a1ab37fd6cb75a5004ffc327fbbfUpdated PHPStan to commit 327fbbf1eb53df137c857e3edfb248d72bfc0de5c38af6eUpdate Larastan810133dUpdated PHPStan to commit 810133debe43c9ef9eca282cecba43595caa4eba029cf3bUpdated PHPStan to commit 029cf3bd4d11ccd966f278f654ac291beebad436Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)