Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the column ID name to the <span> in absence of a link #3923

Closed
wants to merge 3 commits into from

Conversation

loekvangool
Copy link
Contributor

It's possible to determine the column name for admin grids, but not if they are not sortable. I propose to add this.

It's possible to determine the column name for admin grids, but not if they are not sortable. I propose to add this.
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Apr 2, 2024
@fballiano
Copy link
Contributor

Wouldn't it be possible to add the name to the th instead of adding a new DOM element?

Also, https://www.w3schools.com/tags/att_name.asp name isn't a valid attribute for span or for a so... why did they add it to the a element?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants