Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed invalid "shortcut icon" HTML element #3941

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Removed invalid "shortcut icon" HTML element #3941

merged 2 commits into from
Apr 13, 2024

Conversation

fballiano
Copy link
Contributor

Many templates have this "shortcut icon" element (which is just the favicon btw) but shortcut icon is not a valid "rel" type, as explained here: https://www.w3schools.com/tags/att_link_rel.asp

Also, in this page we find:
Screenshot 2024-04-13 alle 13 15 41

That's why this PR removes it.

Note that all templates also have a "icon" link so "shortcut" should be double useless

@github-actions github-actions bot added Template : admin Relates to admin template Template : base Relates to base template Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page Component: Oauth Relates to Mage_Oauth Template : install Relates to install template errors Relates to error pages labels Apr 13, 2024
@fballiano fballiano merged commit c4ecb8b into OpenMage:main Apr 13, 2024
3 checks passed
@fballiano fballiano deleted the shortcuticon branch April 13, 2024 19:09
@fballiano fballiano changed the title Removed invalid "sortcut icon" HTML element Removed invalid "shortcut icon" HTML element May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page errors Relates to error pages Template : admin Relates to admin template Template : base Relates to base template Template : install Relates to install template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants