-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added filemtime to merged JS/CSS hash calculation algorithm #4004
Conversation
If you can I ask you for a review @fballiano |
2076dcf
to
b10cae9
Compare
@fballiano I improved the PR. There was some confusion with the variable name, so your question was legitimate. I have made the code clearer and accepted your suggestion not to run filemtime() several times; |
@boesbo great, I'll test it out a bit |
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the way merging works by default in OM, but that's another topic, I've tested this PR and it does what it claims and I think it's ok to merge
It is only an improvement of the current functionality in view of a modern (now current) management of these assets in the browser cache. Thx! |
If you can I ask you for a review @kasper-agg |
I'll merge this in a couple of days if there's none against |
What @fballiano already mentioned, the whole merging thing is another topic, your PR fixes the current issue at hand 👍 |
Description (*)
Add the timestamp of the files in the MD5 HASH generation criteria of the files.
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)