Switched to ROW_FORMAT DYNAMIC for better compatibility with MariaDB 10.3 / 10.11 #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the tables' row formats of catalog/product_website and catalog/product_relation from FIXED to DYNAMIC
fballiano
reviewed
Jun 3, 2024
app/code/core/Mage/Catalog/sql/catalog_setup/upgrade-1.6.0.0.19.1.6-1.6.0.0.19.1.7.php
Outdated
Show resolved
Hide resolved
|
Is this also supposed to fix new install? cause if I'm not mistaken it seems to fix only already installed projects |
|
I only had already installed shops in my mind. I'll check against a new shop in the next couple of days. |
|
|
also tested a new installation with no problem |
fballiano
approved these changes
Jun 4, 2024
fballiano
changed the title
|
since nobody pitched in, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I increased the version of
Mage/Catalogto run a database migration script to alter the tablescatalog/product_relationsandcatalog_product_websiteto not useROW_FORMAT=FIXEDanymore.I decided to instead use
ROW_FORMAT=DYNAMICbecause it seems to be the standard on MariaDB: https://mariadb.com/kb/en/innodb-dynamic-row-format/For more, see the discussion #3962
Fixed Issues (if relevant)
Database fails to get imported to MariaDB 10.3.* and 10.11.* if InnoDB tables have
ROW_FORMAT=FIXEDQuestions or comments
I did manual tests on MariaDB 10.3 and 10.11. The results are looking good to me. (Meaning: the migration ran throug with success, the shops are still working :) , no apparent error messages or strange behavior)
I guess this should also work on MySQL but I don't have any at hand for testing. So maybe, before approving it, somenone wants to do some testing here.
Contribution checklist (*)