-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: Added "Newsletter Subscription Form" widget #4095
New feature: Added "Newsletter Subscription Form" widget #4095
Conversation
This is a good idea. Maybe we can extend it into another PR to the contact form too. But this would a little bit complex. |
I would prefer not having the constructor only calling parent constructor, but I'll merge it anyway in a couple of days if we don't get more feedback |
I can remove it it's not a problem |
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR. It adds to the list the newsletter widget that I used it on a CMS page. In the Frontend the form is displayed as expected and I successfully subscribed.
@elidrissidev, @kiatng - please stamp this PR with your green color. |
1f3d6b4
Description (*)
Add a new widget with newsletter subscription form.
It is useful for me to be able to insert the newsletter subscription form into CMS pages or Static Blocks.
I have always manually inserted this piece of code:
{{block type="newsletter/subscribe" template="newsletter/subscribe.phtml"}}
With the widget become:
{{widget type="newsletter/widget_subscribe" template="newsletter/subscribe.phtml"}}
But is the same, if you look the new block widget subscribe only extend block subscribe
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)