Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues #4134 undefined array index label_use_default in Mage_Catalog_Model_Product_Attribute_Backend_Media #4136

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Fixed issues #4134 undefined array index label_use_default in Mage_Catalog_Model_Product_Attribute_Backend_Media #4136

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
614229f
fix issues 4134
empiricompany Aug 1, 2024
cc92c45
Merge branch 'main' into issues4134
kiatng Aug 7, 2024
0d001b4
better code
empiricompany Aug 20, 2024
bb22cf4
Merge branch 'main' into issues4134
kiatng Aug 22, 2024
7854a74
Merge branch 'main' into issues4134
kiatng Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,13 @@ public function beforeSave($object)
foreach ($value['values'] as $mediaAttrCode => $attrData) {
if (array_key_exists($attrData, $newImages)) {
$object->setData($mediaAttrCode, $newImages[$attrData]['new_file']);
$object->setData($mediaAttrCode . '_label', ($newImages[$attrData]['label'] === null || $newImages[$attrData]['label_use_default']) ? $newImages[$attrData]['label_default'] : $newImages[$attrData]['label']);
$label = $newImages[$attrData]['label'] === null || !empty($newImages[$attrData]['label_use_default']) ? $newImages[$attrData]['label_default'] : $newImages[$attrData]['label'];
$object->setData($mediaAttrCode . '_label', $label);
}

if (array_key_exists($attrData, $existImages)) {
$object->setData($mediaAttrCode . '_label', ($existImages[$attrData]['label'] === null || $existImages[$attrData]['label_use_default']) ? $existImages[$attrData]['label_default'] : $existImages[$attrData]['label']);
$label = $existImages[$attrData]['label'] === null || !empty($existImages[$attrData]['label_use_default']) ? $existImages[$attrData]['label_default'] : $existImages[$attrData]['label'];
$object->setData($mediaAttrCode . '_label', $label);
}
}

Expand Down
Loading