Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8: Fixes passing null to str_contains() #4203

Merged
merged 1 commit into from
Sep 17, 2024
Merged

PHP8: Fixes passing null to str_contains() #4203

merged 1 commit into from
Sep 17, 2024

Conversation

sreichel
Copy link
Contributor

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Sep 17, 2024
@sreichel sreichel changed the title Fixes passing null to str_contains PHP8: Fixes passing null to `str_contains()` Sep 17, 2024
@sreichel sreichel changed the title PHP8: Fixes passing null to `str_contains()` PHP8: Fixes passing null to str_contains() Sep 17, 2024
@sreichel sreichel merged commit 1c8a5b8 into OpenMage:main Sep 17, 2024
17 checks passed
@sreichel sreichel deleted the fix-4202 branch September 17, 2024 21:40
@sreichel sreichel mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addGrandTotals causes str_contains(): Deprecated functionality Passing null
3 participants
@sreichel @colinmollenhour @addison74