Updated Varien_Object::getData() and added getDataByKey() & getDataByPath()

[sreichel]

Related Pull Requests

• see Updated Varien_Object::getData() and added getDataByKey() & getDataByPath() #3245

I wouldn't know where to start testing it, it's for sure ok but the getdata/setdata is such a core thing that a minor mistake will break everything and there are many use cases to test.
is it absolutely safe to merge it in main?

Current Varien_Object::getData() is 100% covered by unit tests:

After that PR everything works as expected:

It is safe to merge.

[kiatng]

Tested:

        $o = new Varien_Object([
            'a' => [
                'b' => [
                    'c' => 'value c'
                ]
            ],
            'key' => 'value',
            'lines' => "line1\nline2\nline3",
            'vo' => new Varien_Object([
                'a' => 'value a'
            ])
        ]);
        $result = [
            //'a' => $o->getData('a'),
            'a/b/c' => $o->getData('a/b/c'),
            'key' => $o->getData('key'),
            //'lines' => $o->getData('lines'),
            'line2' => $o->getData('lines', 1),
            //'vo' => $o->getData('vo'),
            'vo/a' => $o->getData('vo/a')
        ]

Result:

 array(4) {
  ["a/b/c"] => string(7) "value c"
  ["key"] => string(5) "value"
  ["line2"] => string(5) "line2"
  ["vo/a"] => string(7) "value a"
}