Openmage admin theme: Change background-color for active sections #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : admin
|
I am not using the OpenMage Backend theme but I will give it a try. Please post a few screenshots to understand what is wrong and how looks the fix. |
|
Neither in legacy nor in openmage theme active section /menu is highlighted. There is only a hover-effect. After this PR the active section/menu is not white, its lightgrey.
|
|
It works as expected for the OpenMage theme. For Magento legacy theme there was a discussion here #3452 (comment). |
addison74
approved these changes
Sep 22, 2024
|
For legacy theme, please add SCSS files ;) Here you go https://jsonformatter.org/css-to-scss ... |
kiatng
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Lightgrey background for active sections.
No changes for legacy theme. Dont want to work with plain CSS files.
Maybe someone wants to add SCSS-files for it .... there are some online converters, that do it.
Fixed Issues (if relevant)