-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fixes ENV overriding config #4258
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/unit/Mage/Core/Helper/EnvironmentConfigLoaderTest.php
github-actions
bot
added
environment
Component: PayPal
Relates to Mage_Paypal
Component: Core
Relates to Mage_Core
Component: Catalog
Relates to Mage_Catalog
Component: Reports
Relates to Mage_Reports
Component: Checkout
Relates to Mage_Checkout
Component: lib/Varien
Relates to lib/Varien
Component: Sales
Relates to Mage_Sales
Component: Usa
Relates to Mage_Usa
Component: Eav
Relates to Mage_Eav
Component: Adminhtml
Relates to Mage_Adminhtml
labels
Oct 8, 2024
github-actions
bot
added
Component: Page
Relates to Mage_Page
Component: Captcha
Relates to Mage_Captcha
Component: Admin
Relates to Mage_Admin
Component: Tax
Relates to Mage_Tax
Component: Bundle
Relates to Mage_Bundle
Component: Api2
Relates to Mage_Api2
Component: Rss
Relates to Mage_Rss
Component: lib/*
Relates to lib/*
composer
Relates to composer.json
phpstan
phpunit
ddev
rector
labels
Oct 8, 2024
Clean PR later ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Admin
Relates to Mage_Admin
Component: Adminhtml
Relates to Mage_Adminhtml
Component: Api2
Relates to Mage_Api2
Component: Bundle
Relates to Mage_Bundle
Component: Captcha
Relates to Mage_Captcha
Component: Catalog
Relates to Mage_Catalog
Component: Checkout
Relates to Mage_Checkout
Component: Core
Relates to Mage_Core
Component: Eav
Relates to Mage_Eav
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
Component: Page
Relates to Mage_Page
Component: PayPal
Relates to Mage_Paypal
Component: Reports
Relates to Mage_Reports
Component: Rss
Relates to Mage_Rss
Component: Sales
Relates to Mage_Sales
Component: Tax
Relates to Mage_Tax
Component: Usa
Relates to Mage_Usa
composer
Relates to composer.json
ddev
environment
phpstan
phpunit
rector
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Work in progress ...
Mage::getStoreConfig()
Broken ...
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Set php ENV variables ... for DDEV (to match tests)
Comments
This is not nearly perfect, but may help @pquerner and others to debug.
This PR is NOT based on main-branch, but on #4236.
See ec2c8a9 for relevant changes.
@pquerner @boesbo please check.