Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: passing invalid ID to Mage_Catalog_Model_Url::refreshRewrites() #4259

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Bugfix: passing invalid ID to Mage_Catalog_Model_Url::refreshRewrites() #4259

merged 1 commit into from
Oct 9, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 9, 2024 •
edited
Loading

Description (*)

Part of #4236

Passing an invalid $storeId to Mage_Catalog_Model_Url::refreshRewrites($storeId) leads to multiple errors trying call methods on array.

To reproduce:

$model = new Mage_Catalog_Model_Url();
$model->refreshRewrites(999);

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Oct 9, 2024
@sreichel sreichel mentioned this pull request Oct 9, 2024
Merged
@sreichel sreichel merged commit 5a95706 into OpenMage:main Oct 9, 2024
18 checks passed
@sreichel sreichel deleted the bug-4236 branch October 9, 2024 07:39
fballiano added a commit to MahoCommerce/maho that referenced this pull request Oct 9, 2024
@fballiano
OM PR 4259
83439d3 
OpenMage/magento-lts#4259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74