Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit: ignore timezone in date tests #4284

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Phpunit: ignore timezone in date tests #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/unit/Mage/Core/Helper/DataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function testFormatTimezoneDate(
$data,
string $format = Mage_Core_Model_Locale::FORMAT_TYPE_SHORT,
bool $showTime = false,
bool $useTimezone = true
bool $useTimezone = false # disable timezone by default for tests
): void {
$this->assertSame($expectedResult, $this->subject->formatTimezoneDate($data, $format, $showTime, $useTimezone));
}
Expand Down Expand Up @@ -131,12 +131,6 @@ public function provideFormatTimezoneDate(): Generator
$date,
'long'
];
// yield 'date short w/ time and w/ timezone' => [
// $dateShortTime,
// $date,
// 'short',
// true
// ];
yield 'date short w/ time' => [
$dateShortTime,
$date,
Expand Down
Loading