Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some phpStan fixes #4290

Closed
wants to merge 2 commits into from
Closed

Some phpStan fixes #4290

wants to merge 2 commits into from

Conversation

sreichel
Copy link
Contributor

Description (*)

Move phpstan fixes from #4204

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Captcha Relates to Mage_Captcha Component: Admin Relates to Mage_Admin Component: SalesRule Relates to Mage_SalesRule Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Shipping Relates to Mage_Shipping Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: ImportExport Relates to Mage_ImportExport Component: lib/* Relates to lib/* phpstan Component: lib/Magento Relates to lib/Magento labels Oct 18, 2024
addison74
addison74 previously approved these changes Oct 18, 2024
View reviewed changes
@sreichel sreichel mentioned this pull request Oct 18, 2024
Merged
@sreichel
Copy link
Contributor Author

Merged into #4291

@sreichel sreichel closed this Oct 18, 2024
@sreichel sreichel deleted the phpstan-u branch October 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 left review comments

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Magento Relates to lib/Magento Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Weee Relates to Mage_Weee Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @addison74