Fix Mage_Adminhtml_Block_Template::isOutputEnabled() for invalid module
#4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Core
addison74
previously approved these changes
Oct 29, 2024
justinbeaty
reviewed
Oct 29, 2024
justinbeaty
reviewed
Oct 29, 2024
Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
justinbeaty
reviewed
Oct 29, 2024
justinbeaty
approved these changes
Oct 29, 2024
Merged
addison74
approved these changes
Oct 29, 2024
kiatng
approved these changes
Oct 30, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 30, 2024
github-actions bot
pushed a commit
to tmewes/maho
that referenced
this pull request
Oct 31, 2024
…dule (#4320) * fix isOutputEnabled * Update tests/unit/Mage/Adminhtml/Block/TemplateTest.php Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com> * fix OpenMage/magento-lts#4320 (comment) * updated tests --------- Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
github-actions bot
pushed a commit
to 5mehulhelp5/maho
that referenced
this pull request
Oct 31, 2024
…dule (#4320) * fix isOutputEnabled * Update tests/unit/Mage/Adminhtml/Block/TemplateTest.php Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com> * fix OpenMage/magento-lts#4320 (comment) * updated tests --------- Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
github-actions bot
pushed a commit
to mdsxbm/maho
that referenced
this pull request
Oct 31, 2024
…dule (#4320) * fix isOutputEnabled * Update tests/unit/Mage/Adminhtml/Block/TemplateTest.php Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com> * fix OpenMage/magento-lts#4320 (comment) * updated tests --------- Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
github-actions bot
pushed a commit
to MahoCommerce/maho
that referenced
this pull request
Oct 31, 2024
…dule (#4320) * fix isOutputEnabled * Update tests/unit/Mage/Adminhtml/Block/TemplateTest.php Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com> * fix OpenMage/magento-lts#4320 (comment) * updated tests --------- Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
github-actions bot
pushed a commit
to justinbeaty/maho
that referenced
this pull request
Oct 31, 2024
…dule (#4320) * fix isOutputEnabled * Update tests/unit/Mage/Adminhtml/Block/TemplateTest.php Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com> * fix OpenMage/magento-lts#4320 (comment) * updated tests --------- Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Mage_Adminhtml_Block_Template::isOutputEnabled()returns false now for non-existing module.Manual testing scenarios (*)