Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump friendsofphp/php-cs-fixer from 3.64.0 to 3.65.0 #4380

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Bumps friendsofphp/php-cs-fixer from 3.64.0 to 3.65.0.

Release notes

Sourced from friendsofphp/php-cs-fixer's releases.

v3.65.0 Persian Successor

What's Changed

... (truncated)

Changelog

Sourced from friendsofphp/php-cs-fixer's changelog.

Changelog for v3.65.0

  • feat: Ability to set upper limit when using CPU auto-detection (#8280)
  • feat: create @PHP82Migration:risky ruleset (#8277)
  • feat: Impl. TypeExpression::mapTypes() (#8077)
  • feat: Parse array/generic/nullable type into inner expression (#8106)
  • feat: phpdoc_to_property_type - handle virtual types and null initialization, enable in php-highest CI job (#8283)
  • feat: Store PHPDoc offset in DataProviderAnalysis (#8226)
  • feat: Support for complex PHPDoc types in fully_qualified_strict_types (#8085)
  • fix: check for priority tests correctly (#8221)
  • fix: Do not mark with @coversNothing if CoversMethod/CoversFunction attribute is used (#8268)
  • fix: enum-case mistaken for const invocation (#8190)
  • fix: fix typing of few properties wrongly typed as non-nullable (#8285)
  • fix: fix typing property wrongly typed as non-nullable (#8290)
  • fix: MethodChainingIndentationFixer does not fix indentation of last chained property (#8080)
  • fix: NoSuperfluousPhpdocTagsFixer - Remove superfluous phpdoc of parameter with attribute (#8237)
  • fix: parsing mixed & and | in TypeExpression (#8210)
  • fix: proper base class used for AbstractDoctrineAnnotationFixer templates generation (#8291)
  • fix: Properly recognise constants in foreach loops (#8203)
  • fix: Tokens::overrideRange() block cache pruning (#8240)
  • fix: BlankLineAfterOpeningTagFixer - add blank line in file starting with multi-line comment (#8256)
  • fix: MultilineWhitespaceBeforeSemicolonsFixer - do not produce syntax error when there is a meaningful token after semicolon (#8230)
  • fix: NullableTypeDeclarationFixer - do not break syntax when there is no space before ? (#8224)
  • fix: PhpUnitDataProvider(.+)Fixer - do not omit when there is an attribute between PHPDoc and test method (#8185)
  • fix: PhpUnitDataProviderNameFixer - for an attribute between PHPDoc and test method (#8217)
  • chore: add todo for PHP v8 (#8274)
  • chore: auto-fallback to sequential runner if single CPU would handle it (#8154)
  • chore: block changing tokens collection size using PhpCsFixer\Tokenizer\Tokens::setSize (#8257)
  • chore: bump dev-tools (#8286)
  • chore: bump PHPStan (#8245)
  • chore: Cheaper file check first (#8252)
  • chore: ConfigInterface - better types (#8244)
  • chore: do not call Tokens::setSize in GroupImportFixer (#8253)
  • chore: do not use Reflection*::setAccessible (#8264)
  • chore: fix priority tests (#8223)
  • chore: Fix typos in AbstractFixerTestCase (#8247)
  • chore: GithubClient - make URL injectable (#8272)
  • chore: Implement PHPStan Preg::match() extensions (#8103)
  • chore: mark remaining Analysis as @internal (#8284)
  • chore: PHPStan - upgrade to v2 (#8288)
  • chore: reduce amount of class mutable properties (#8281)
  • chore: remove from priority tests exceptions tests that are not actually exceptions (#8222)
  • chore: remove incorrect priority tests (#8231)
  • chore: remove not needed PHP version requirements in descriptions (#8265)
  • chore: remove unnecessary methods (#8200)
  • chore: tests/Tokenizer/Transformer - better typehinting (#8243)
  • chore: Token - remove 'changed' property (#8273)
  • chore: Token::getContent() phpdoc return type (#8236)
  • chore: update dev dependencies in root (#8289)

... (truncated)

Commits
  • 79d4f3e prepared the 3.65.0 release
  • 700668e chore: mark remaining Analysis as @internal (#8284)
  • 163a7ed refactor: use arrow functions in more places (#8294)
  • 42f3692 feat: Ability to set upper limit when using CPU auto-detection (#8280)
  • effd9a3 refactor: Rename newly introduced option (#8293)
  • 0adec43 chore: PHPStan - upgrade to v2 (#8288)
  • 52dc062 feat: phpdoc_to_property_type - handle virtual types and null initialization,...
  • ccad080 chore: update dev dependencies in root (#8289)
  • e37cb56 fix: proper base class used for AbstractDoctrineAnnotationFixer templates gen...
  • 17dfe25 fix: fix typing property wrongly typed as non-nullable (#8290)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.64.0 to 3.65.0.
- [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md)
- [Commits](PHP-CS-Fixer/PHP-CS-Fixer@v3.64.0...v3.65.0)

---
updated-dependencies:
- dependency-name: friendsofphp/php-cs-fixer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file MINOR This PR is intended to be treated as a MINOR update according to RFC-0002 php Pull requests that update Php code labels Nov 25, 2024
@github-actions github-actions bot added the composer Relates to composer.json label Nov 25, 2024
addison74
addison74 previously approved these changes Nov 25, 2024
@sreichel
Copy link
Contributor

@addison74 why approve? Red check?

@sreichel
Copy link
Contributor

sreichel commented Nov 25, 2024

Interessting. This changes should already had been made.

In .php-cs-fixer.dist.php we have this rule .

// Ensure there is no code on the same line as the PHP open tag and it is followed by a blank line.
'blank_line_after_opening_tag' => true,

It has been fixed in PHP-CS-Fixer/PHP-CS-Fixer#8256. I could set the rule to false, but then the error would re-appear in #4372, where all custom rules - that are part of PSR-12/PER-2 are removed.

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: AdminNotification Relates to Mage_AdminNotification Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Cron Relates to Mage_Cron Component: Captcha Relates to Mage_Captcha Component: Contacts Relates to Mage_Contacts Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: CatalogRule Relates to Mage_CatalogRule Component: Admin Relates to Mage_Admin Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle and removed composer Relates to composer.json labels Nov 25, 2024
@github-actions github-actions bot added Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Test Results

511 tests  ±0   503 ✅ ±0   2s ⏱️ ±0s
136 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f51f714. ± Comparison against base commit f153ced.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Test Results

511 tests  ±0   503 ✅ ±0   2s ⏱️ ±0s
136 suites ±0     4 💤 ±0 
  1 files   ±0     0 ❌ ±0   4 🔥 ±0 

For more details on these errors, see this check.

Results for commit e47caf7. ± Comparison against base commit af8dad9.

@sreichel sreichel merged commit afa1346 into main Nov 25, 2024
39 checks passed
@dependabot dependabot bot deleted the dependabot/composer/friendsofphp/php-cs-fixer-3.65.0 branch November 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav dependencies Pull requests that update a dependency file MINOR This PR is intended to be treated as a MINOR update according to RFC-0002 php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants