Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWD theme: use jQuery via composer #4429

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 25, 2024

Description (*)

#3204 (comment)

Replaced jquery files with https://github.com/components/jquery.

If v3.7.1 causes troube you can additional load jquery-migration.js. See new config option.

You can also downgrade to use any other version

composer require components/jquery:<x.y.z>

Related Pull Request

@github-actions github-actions bot added Component: Core Relates to Mage_Core Template : rwd Relates to rwd template Component: Page Relates to Mage_Page composer Relates to composer.json JavaScript Relates to js/* XML Layout git labels Dec 25, 2024
@sreichel sreichel added this to the 20.12.0 milestone Dec 25, 2024
@addison74
Copy link
Contributor

This PR will cause a BC because most of the existing extensions are based on jQuery v1 (on which the RWD theme is based). With the latest version v1 I have no issues in the browser console running the code, but by switching to v3, many errors immediately appear that require time to be fixed.

@sreichel
Copy link
Contributor Author

sreichel commented Dec 25, 2024

I have checked a couple of pages and had no console errors with v3. And in next branch no changes were made to template.

Id prefer to deliver v3 as default.

@Axepih
Copy link

Axepih commented Dec 27, 2024

mini change in .github/codeql-config.yml
to be modified, as the path no longer exists

@sreichel sreichel changed the title RWD theme: use jQuery 3.7.1 via composer RWD theme: use jQuery via composer Dec 30, 2024
# Conflicts:
#	composer.lock
@sreichel
Copy link
Contributor Author

Downgrade back 1.12.4 to remove that files from repos at least.

@addison74 update to 3.7.1 should be discussed or voted for.

@addison74
Copy link
Contributor

I've been thinking to this PR for a while now and I'm not against upgrading to v3, but at least for OpenMage, checks must be made to ensure there are no errors or malfunctions in the code. It could be a draft for a few months.

@sreichel
Copy link
Contributor Author

So lets merge it and anyone can test composer require components/jquery:3.7.1 until next PR/discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core Component: Page Relates to Mage_Page composer Relates to composer.json git JavaScript Relates to js/* Template : rwd Relates to rwd template XML Layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants