-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RWD theme: use jQuery via composer #4429
base: main
Are you sure you want to change the base?
Conversation
This PR will cause a BC because most of the existing extensions are based on jQuery v1 (on which the RWD theme is based). With the latest version v1 I have no issues in the browser console running the code, but by switching to v3, many errors immediately appear that require time to be fixed. |
I have checked a couple of pages and had no console errors with v3. And in next branch no changes were made to template. Id prefer to deliver v3 as default. |
mini change in .github/codeql-config.yml |
# Conflicts: # composer.lock
Downgrade back 1.12.4 to remove that files from repos at least. @addison74 update to 3.7.1 should be discussed or voted for. |
I've been thinking to this PR for a while now and I'm not against upgrading to v3, but at least for OpenMage, checks must be made to ensure there are no errors or malfunctions in the code. It could be a draft for a few months. |
So lets merge it and anyone can test |
Description (*)
#3204 (comment)
Replaced jquery files with https://github.com/components/jquery.
If v3.7.1 causes troube you can additional load
jquery-migration.js
. See new config option.You can also downgrade to use any other version
Related Pull Request