Couponcode adminhtml updated pull #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view) solve longstanding order shortcoming (so actual coupon code on order view in adminhtml) now our logistics see the description @ totals overview: but have to ask the customer: which code was it? esp. handy when using generated codes simple fix: please improve if you think this can be done better. Breaks nothing, quickwin for admin users
colinmollenhour
previously approved these changes
Mar 9, 2018
|
Whilst I haven't investigated, how the values pass through the system, both |
|
If it doesn’t break anything why not add the change? Please edit the change
Also
In some advanced cases more than 1 code can be applied. So maybe check for
multiple values too for these exotic cases
…On Wed, 14 Mar 2018 at 22:04, pocallaghan ***@***.***> wrote:
Whilst I haven't investigated, how the values pass through the system,
both $_order->getCouponCode() and $_order->getDiscountDescription()
should likely be escaped before passing them to translate. Off the top of
my head, I don't think a frontend user can insert an arbitrary value, so
it's probable that you'd require admin access to exploit, but it's always
good practice to escape such data. It's possible that with access to a
limited administrative account, privileges could be escalated through use
of persistent XSS in these fields.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#447 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAn0a8C9gwkLRCNkNGZ6o9bmkao0Hokbks5teYXQgaJpZM4R-WCv>
.
|
|
Good observation, @pocallaghan. PR updated. Thanks! |
colinmollenhour
approved these changes
Oct 4, 2018
tbaden
approved these changes
Jun 1, 2019
sreichel
added
Component: Sales
Sekiphp
pushed a commit
to Sekiphp/magento-lts
that referenced
this pull request
Apr 10, 2021
* solve longstanding order shortcoming (so actual coupon code on order view) solve longstanding order shortcoming (so actual coupon code on order view in adminhtml) now our logistics see the description @ totals overview: but have to ask the customer: which code was it? esp. handy when using generated codes simple fix: please improve if you think this can be done better. Breaks nothing, quickwin for admin users * Sloppy missed clsoing div * Updated string * Add coupon code translations * Update Mage_Adminhtml.csv * Added coupon code * Escape coupon code and description in template. Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
Flyingmana
pushed a commit
that referenced
this pull request
Jul 30, 2021
* solve longstanding order shortcoming (so actual coupon code on order view) solve longstanding order shortcoming (so actual coupon code on order view in adminhtml) now our logistics see the description @ totals overview: but have to ask the customer: which code was it? esp. handy when using generated codes simple fix: please improve if you think this can be done better. Breaks nothing, quickwin for admin users * Sloppy missed clsoing div * Updated string * Add coupon code translations * Update Mage_Adminhtml.csv * Added coupon code * Escape coupon code and description in template. Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couponcode adminhtml updated pull
no squash merge here otherwise would have bundled in 1