Fix Coupon Removal Failure When Shipping/Tax Is Applied To Quote #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is based on Issue OpenMage#508 In the Shopping Cart, when you use the estimate shipping/tax feature, apply the estimations to the order, add a coupon code to the order, and then remove the coupon, the Shopping Cart returns the "Coupon code was canceled." messages, however, the coupon remains attached to the quote/sale. If you do not use the estimate shipping/tax feature, the coupon can be added and then removed without issue. LAMP Stack Linux: Ubuntu 16.04.10 (AWS Ubuntu 16.04 AMI) Apache: Apache/2.4.18 (Ubuntu) MySQL: Ver 15.1 Distrib 10.1.35-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 PHP: PHP 7.0.30-0ubuntu0.16.04.1 (cli) Magento CE Version: 1.9.3.9 Modules Active In Local Pool: Inchoo_PHP7 Modules Active In Community Pool: Cm_RedisSession Active Theme: base/default
Flyingmana
suggested changes
Aug 31, 2018
| @@ -620,6 +620,7 @@ public function couponPostAction() | |||
| } | |||
| } else { | |||
| $this->_getSession()->addSuccess($this->__('Coupon code was canceled.')); | |||
| $this->_getSession()->setCartCouponCode($couponCode); | |||
There was a problem hiding this comment.
I would suggest to do it above the message, to if something goes wrong with setting, it happens before we send out the message.
besides that I think it would make more sense, to directly set en empty string, or even Null(does Null work there?)
The empty string, because if the else is triggered, this means $codeLength did resolve to false
tbaden
added
code change requested
sreichel
added
bug
duplicate
and removed
review needed
|
Closed with #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on Issue #508
In the Shopping Cart, when you use the estimate shipping/tax feature, apply the estimations to the order, add a coupon code to the order, and then remove the coupon, the Shopping Cart returns the "Coupon code was canceled." messages, however, the coupon remains attached to the quote/sale.
If you do not use the estimate shipping/tax feature, the coupon can be added and then removed without issue.
LAMP Stack
Linux: Ubuntu 16.04.10 (AWS Ubuntu 16.04 AMI)
Apache: Apache/2.4.18 (Ubuntu)
MySQL: Ver 15.1 Distrib 10.1.35-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
PHP: PHP 7.0.30-0ubuntu0.16.04.1 (cli)
Magento CE Version: 1.9.3.9
Modules Active In Local Pool:
Inchoo_PHP7
Modules Active In Community Pool:
Cm_RedisSession
Active Theme: base/default