fixed return value of saveCache method #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrieger85
approved these changes
Jun 2, 2019
tmotyl
approved these changes
Apr 24, 2020
|
@colinmollenhour the other change was yours, so please review it. For me it looks ok. |
|
This method is only ever called once and the return value is ignored in that case. Also the |
|
There may be others depending on that return value. Changing this just does not make any sense IMHO. It is just not proper OOP to completely change a return value (even the type!). |
colinmollenhour
approved these changes
Apr 27, 2020
Sekiphp
pushed a commit
to Sekiphp/magento-lts
that referenced
this pull request
Apr 10, 2021
Flyingmana
pushed a commit
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original method did not return a boolean value, but the return value of
Mage_Core_Model_App::saveCache. See https://github.com/OpenMage/magento-mirror/blob/fe6a94e281cb3e8e166f4eece31c4df1faa8cec6/app/code/core/Mage/Core/Model/Layout/Update.php#L198.