Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing variables and functions added #6

Closed
wants to merge 3 commits into from
Closed

Missing variables and functions added #6

wants to merge 3 commits into from

Conversation

syammohanmp
Copy link

No description provided.

@LeeSaferite
Copy link
Contributor

Can you please explain this PR?

What is the bug?
Does this break current behaviour?

@syammohanmp
Copy link
Author

Check the below file
app/design/frontend/base/default/template/page/template/linksblock.phtml

  1. Undefined functions
    a. $this->getLiParams()
    b . $this->getAParams()
  2. Spelling or Naming convention Mistake
    a. protected $_liPparams = null;
    b. protected $_aPparams = null;

I have fixed this BUG in my PR and it doesn't break any Magento core features.

@drobinson
Copy link
Collaborator

@LeeSaferite looks like this block isn't used by Magento Core anywhere.
@syamvilakudy Diff looks good, but can you create a pull request with just the relevant commit (dd054c6)?

@syammohanmp
Copy link
Author

Ok , I will create a new pull request

@syammohanmp
Copy link
Author

@drobinson , I have created a PR with latest file ( Copyright (c) 2006-2015 X.commerce )
#14

@drobinson drobinson closed this May 5, 2015
@tomekjordan tomekjordan mentioned this pull request Feb 1, 2017
Closed
@tomekjordan tomekjordan mentioned this pull request Feb 22, 2017
Closed
@urbancrew urbancrew mentioned this pull request Nov 22, 2017
Closed
@seansan seansan mentioned this pull request Apr 16, 2019
Closed
@digitalpianism digitalpianism mentioned this pull request Sep 7, 2020
Closed
@bojandavkov bojandavkov mentioned this pull request Sep 16, 2020
Closed
@seansan seansan mentioned this pull request Sep 30, 2020
Closed
@jouriy jouriy mentioned this pull request Nov 23, 2020
Closed
@S0FTWEX S0FTWEX mentioned this pull request Apr 9, 2021
Closed
@CyberCr33p CyberCr33p mentioned this pull request Jan 8, 2022
Closed
@alexh-swdev alexh-swdev mentioned this pull request Sep 21, 2022
Closed
justinbeaty added a commit to justinbeaty/magento-lts that referenced this pull request Jan 16, 2023
@justinbeaty
Improvements (OpenMage#6)
a7a2b93
@Jattura Jattura mentioned this pull request Mar 9, 2023
Closed
@matteotestoni matteotestoni mentioned this pull request Mar 16, 2023
Closed
@andyt andyt mentioned this pull request Apr 24, 2023
Closed
@alexh-swdev alexh-swdev mentioned this pull request Aug 9, 2023
Closed
sreichel referenced this pull request in openmage-strict/openmage-future Feb 16, 2024
@sreichel
PHP8: fixes passing null in `Mage_Adminhtml_Block_System_Convert_Gui_…
c562b79 
…Edit_Tab_Wizard::getValue()` (#6)

* PHP8: fixes passing null in Mage_Adminhtml_Block_System_Convert_Gui_Edit_Tab_Wizard::getValue()

* Added docblock to template
@r-martins r-martins mentioned this pull request Oct 7, 2024
Open
@LuizSantos22 LuizSantos22 mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syammohanmp @LeeSaferite @drobinson @sreichel