add some logging for errors during paypal response validation #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion to add some logging if in error https://community.magento.com/t5/Payments-PayPal/PayPal-response-hasn-t-required-fields-AMT-field-is-deprecated/td-p/51852
tmotyl
reviewed
Mar 29, 2019
| @@ -1164,6 +1164,7 @@ protected function _validateResponse($method, $response) | |||
| if (isset($this->_requiredResponseParams[$method])) { | |||
| foreach ($this->_requiredResponseParams[$method] as $param) { | |||
| if (!isset($response[$param])) { | |||
| Mage::log("Expected PayPal field not found in NVP Response: $param"); | |||
There was a problem hiding this comment.
Please log more context, right now the log is not really useful. You see that sth is wrong but has no idea which order was it and which paypal method caused the issue.
There was a problem hiding this comment.
do we have any order identifying data available in this context?
|
According to OP this works fine. Also I am glad "at least" there is some
log.
Please add to the pull request if there is more info you need that you are
missing
…On Fri, Mar 29, 2019 at 2:46 PM Tymoteusz Motylewski < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/code/core/Mage/Paypal/Model/Api/Nvp.php
<#640 (comment)>:
> @@ -1164,6 +1164,7 @@ protected function _validateResponse($method, $response)
if (isset($this->_requiredResponseParams[$method])) {
foreach ($this->_requiredResponseParams[$method] as $param) {
if (!isset($response[$param])) {
+ Mage::log("Expected PayPal field not found in NVP Response: $param");
Please log more context, right now the log is not really useful. You see
that sth is wrong but has no idea which order was it and which paypal
method caused the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#640 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAn0a4L2zpfD3FLwlQA-1yYwhrMQiZYNks5vbhkqgaJpZM4cSDbS>
.
|
sreichel
approved these changes
Apr 3, 2019
Flyingmana
approved these changes
May 16, 2021
Flyingmana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to add some logging if in error
https://community.magento.com/t5/Payments-PayPal/PayPal-response-hasn-t-required-fields-AMT-field-is-deprecated/td-p/51852