Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage_Core - DOC block update #702

Merged
merged 7 commits into from
Jun 5, 2020
Merged

Mage_Core - DOC block update #702

merged 7 commits into from
Jun 5, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jun 2, 2019

#692 just from own repo.

@kkrieger85 kkrieger85 added the review needed Problem should be verified label Jun 3, 2019
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreichel Thank you for your work :)

kkrieger85
kkrieger85 previously approved these changes Jun 4, 2019
Flyingmana
Flyingmana previously approved these changes Jun 5, 2019
app/code/core/Mage/Core/Block/Abstract.php Outdated Show resolved Hide resolved
app/code/core/Mage/Core/Model/App/Emulation.php Outdated Show resolved Hide resolved
app/code/core/Mage/Core/Model/Observer.php Outdated Show resolved Hide resolved
- changes from reviews
- added some @methods
- reverted some changes in code style for less diffs
@sreichel sreichel dismissed stale reviews from Flyingmana and kkrieger85 via 956cbb3 June 5, 2019 13:11
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Jun 16, 2019
@sreichel sreichel removed the review needed Problem should be verified label Jun 23, 2019
app/code/core/Mage/Core/Block/Template.php Outdated Show resolved Hide resolved
app/code/core/Mage/Core/Model/Cache.php Outdated Show resolved Hide resolved
app/code/core/Mage/Core/Model/Resource.php Outdated Show resolved Hide resolved
app/code/core/Mage/Core/Model/Resource.php Outdated Show resolved Hide resolved
@sreichel sreichel added the hold label May 12, 2020
@sreichel sreichel removed the hold label May 22, 2020
@sreichel sreichel requested a review from tmotyl May 22, 2020 18:18
This was referenced May 22, 2020
@sreichel sreichel added the Component: Core Relates to Mage_Core label Jun 4, 2020
@colinmollenhour colinmollenhour merged commit 8ca6fd9 into OpenMage:1.9.4.x Jun 5, 2020
@sreichel sreichel deleted the cleanup/docs/Core branch June 5, 2020 22:56
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants