Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_CurrencySymbol - DOC block update #708

Merged
merged 3 commits into from
May 14, 2020
Merged

Mage_CurrencySymbol - DOC block update #708

merged 3 commits into from
May 14, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jun 4, 2019

  • add missing properties

@sreichel
Mage CurrencySymbol - DOC block update
3945b53 
- add missing properties
@sreichel sreichel changed the title Mage CurrencySymbol - DOC block update Mage_CurrencySymbol - DOC block update Jun 4, 2019
kkrieger85
kkrieger85 previously approved these changes Jun 5, 2019
View reviewed changes
@kkrieger85 kkrieger85 added the review needed Problem should be verified label Jun 5, 2019
Sekiphp
Sekiphp suggested changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@Sekiphp Sekiphp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Jun 16, 2019
@sreichel
Mini update
ab120ac 
- fixed camelcase class name
@sreichel sreichel removed the review needed Problem should be verified label Jun 23, 2019
@sreichel sreichel added the hold label May 9, 2020
@sreichel sreichel mentioned this pull request May 9, 2020
Closed
6 tasks
@sreichel sreichel removed the hold label May 9, 2020
@sreichel sreichel requested review from kkrieger85 and tmotyl May 9, 2020 21:07
@colinmollenhour colinmollenhour merged commit d61686a into OpenMage:1.9.4.x May 14, 2020
@sreichel sreichel deleted the cleanup/docs/CurrencySymbol branch May 19, 2020 01:40
@sreichel sreichel added the Component: CurrencySymbol Relates to Mage_CurrencySymbol label Jun 5, 2020
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
@sreichel sreichel mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekiphp Sekiphp Sekiphp requested changes

@tmotyl tmotyl tmotyl approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kkrieger85 kkrieger85 kkrieger85 left review comments

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: CurrencySymbol Relates to Mage_CurrencySymbol
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sreichel @colinmollenhour @tmotyl @kkrieger85 @Sekiphp