Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widgets layout handle on edit #802

Merged
merged 2 commits into from
May 23, 2021

Conversation

VincentMarmiesse
Copy link
Contributor

Hi,
There is an issue when you edit a widget: it does not select the right layout handle.

Example, if you create a core/text_list block on handle cms_index_index:

<?xml version="1.0" encoding="UTF-8" ?>
<layout version="0.1.0">
    <cms_index_index>
        <reference name="content">
            <block type="core/text_list" name="home.area" translate="label">
                <label>Homepage area</label>
            </block>
        </reference>
    </cms_index_index>
</layout>

The area will appear when you create a widget but not when you edit one. That's because the select is not correct in template file.

@sreichel sreichel added Component: Widget Relates to Mage_Widget Template : admin Relates to admin template labels Jun 6, 2020
julienloizelet
julienloizelet previously approved these changes Jul 7, 2020
Copy link
Contributor

@julienloizelet julienloizelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ok.

To reproduce bug :

  • create local.xml as suggested
  • create a widget and select Display on specific pages > Cms home Page : you will be able to choose the Homepage area added in local.xml
  • But as soon as you save the widget (i.e you are now in edition mode), the option disappears from the select.
  • On the PR branch, it works as expected.

colinmollenhour
colinmollenhour previously approved these changes Jul 7, 2020
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jul 24, 2020
@Flyingmana Flyingmana merged commit 0eda1e5 into OpenMage:1.9.4.x May 23, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 0eda1e5. ± Comparison against base commit 0c17182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Widget Relates to Mage_Widget Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants