Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EU country #842

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

spinsch
Copy link
Contributor

@spinsch spinsch commented Oct 23, 2019

@Flyingmana
Copy link
Contributor

not sure about the update script, there may still come an official patch adding an update script for this version.
also, isnt there a chance for complications if we just delete the config entry?

@spinsch
Copy link
Contributor Author

spinsch commented Oct 23, 2019

The EU list can be adjusted in the backend. It may happen that someone has complications.
I saw no other way to add a new country to existing installations. Should I skip the upgrade script?

@Flyingmana
Copy link
Contributor

For now its probably better to skip the update script.
We can add it at a later point (after the EOL of M1), and then also wait for a bit of feedback from other people.
But in general, as its already configurable, there is no need to update it for existing installations I think

@hhirsch
Copy link
Contributor

hhirsch commented Nov 4, 2019

@spinsch If I understand correctly this can be pulled if you remove the upgrade script from the PR. Can you upgrade your PR?

@spinsch spinsch force-pushed the spinsch-fix-losteucountry branch from 473c0f7 to cfc6305 Compare November 4, 2019 15:31
@spinsch
Copy link
Contributor Author

spinsch commented Nov 4, 2019

@hhirsch yes exactly. I'm a little busy at the moment. :)

@colinmollenhour colinmollenhour merged commit 25f17b0 into OpenMage:1.9.4.x Jan 21, 2020
@sreichel sreichel added this to the Release 19.4.1 milestone Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants